Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non set table_id default to 0 or all tables for deletion? #195

Open
viniarck opened this issue Aug 21, 2024 · 0 comments
Open

Non set table_id default to 0 or all tables for deletion? #195

viniarck opened this issue Aug 21, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@viniarck
Copy link
Member

Related to kytos-ng/mef_eline#497 (comment)

Quoting the OF1.3 spec:

The table_id chooses the table to which the configuration change should be applied. If the table_id is OFPTT_ALL, the configuration is applied to all tables in the switch.

On pyof a FlowMod table_id defaults to 0, which for installing flows makes a lot of sense. For deletion it makes sense too, but the code we use to perform a non stric deletino is considering a non set table_id same as OFPTT_ALL so it'll delete form the DB, but it'll set on wire the flowmod only deleting from table 0, and then consistency check will eventually delete. So, it's not a great behavior.

Considering other default values, I think it makes sense for deletion to assume table 0 only to also simplify logic in the code, and if users want all tables, they need to set table_id: OFPTT_ALL. I think this would result in the least surprising behavior. This discussion will continue when this gets prioritized eventually

Thanks for confirming @Alopalao kytos-ng/mef_eline#497 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant