Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: FlowMods that can't be packed should not be sent and should return http 400 #136

Closed
viniarck opened this issue Feb 17, 2023 · 0 comments · Fixed by #137
Closed

feat: FlowMods that can't be packed should not be sent and should return http 400 #136

viniarck opened this issue Feb 17, 2023 · 0 comments · Fixed by #137
Assignees
@viniarck
Labels
2022.3 Kytos-ng 2022.3 enhancement New feature or request

Comments

@viniarck
Copy link
Member

Related to kytos-ng/of_core#102,

This won't mitigate all validations yet, but will mitigate the related issue from happening again. Since flow_manager is responsible for owning and pushing FlowMods that should help out to minimize the surface of potential serialization pack bugs.

This is originally partly related to #43 for the record
@viniarck viniarck added enhancement New feature or request in_progress In progress 2022.3 Kytos-ng 2022.3 labels Feb 17, 2023
@viniarck viniarck self-assigned this Feb 17, 2023
@viniarck viniarck changed the title feat: FlowMods that can't be packed should not be set and return http 400 feat: FlowMods that can't be packed should not be sent and should return http 400 Feb 17, 2023
@viniarck viniarck mentioned this issue Feb 17, 2023
Merged
@viniarck viniarck removed the in_progress In progress label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viniarck viniarck

Labels
2022.3 Kytos-ng 2022.3 enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@viniarck