Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting in the Gateway API tutorial #983

Merged
merged 2 commits into from
Aug 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions docs/user/tutorials/01-20-expose-httbin-gateway-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ The Istio module does not install Gateway API CustomResourceDefinitions (CRDs).

```bash
kubectl get crd gateways.gateway.networking.k8s.io &> /dev/null || \
{ kubectl kustomize "github.com/kubernetes-sigs/gateway-api/config/crd?ref=v1.1.0" | kubectl apply -f -; }
{ kubectl kustomize "github.com/kubernetes-sigs/gateway-api/config/crd?ref=v1.1.0" | kubectl apply -f -; }
```

> [!NOTE]
Expand Down Expand Up @@ -63,8 +63,8 @@ kubectl get crd gateways.gateway.networking.k8s.io &> /dev/null || \
EOF
```

> [!NOTE]
> This command deploys the Istio Ingress service in your namespace with the corresponding Kubernetes Service of type `LoadBalanced` and an assigned external IP address.
> [!NOTE]
> This command deploys the Istio Ingress service in your namespace with the corresponding Kubernetes Service of type `LoadBalanced` and an assigned external IP address.

2. Create an HTTPRoute to configure access to your workload:

Expand Down Expand Up @@ -100,11 +100,11 @@ kubectl get crd gateways.gateway.networking.k8s.io &> /dev/null || \
export INGRESS_PORT=$(kubectl get gtw httpbin-gateway -n $NAMESPACE -o jsonpath='{.spec.listeners[?(@.name=="http")].port}')
```

2. Call an HTTPBin Service:
2. Call the HTTPBin Service:

```bash
curl -s -I -HHost:httpbin.kyma.example.com "http://$INGRESS_HOST:$INGRESS_PORT/headers"
```
> [!NOTE]
> This tutorial assumes there's no DNS setup for the `httpbin.kyma.example.com` host, so the call contains the host header.

> [!NOTE]
> This tutorial assumes there's no DNS setup for the `httpbin.kyma.example.com` host, so the call contains the host header.
8 changes: 4 additions & 4 deletions docs/user/tutorials/01-30-expose-tcp-gateway-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ kubectl get crd gateways.gateway.networking.k8s.io &> /dev/null || \
kubectl create -n $NAMESPACE -f https://raw.githubusercontent.com/istio/istio/release-1.22/samples/tcp-echo/tcp-echo.yaml
```

### Expose an TCPEcho Service
### Expose a TCPEcho Service

1. Create a Kubernetes Gateway to deploy Istio Ingress Gateway:

Expand All @@ -71,8 +71,8 @@ kubectl get crd gateways.gateway.networking.k8s.io &> /dev/null || \
EOF
```

> [!NOTE]
> This command deploys the Istio Ingress service in your namespace with the corresponding Kubernetes Service of type `LoadBalanced` and an assigned external IP address.
> [!NOTE]
> This command deploys the Istio Ingress service in your namespace with the corresponding Kubernetes Service of type `LoadBalanced` and an assigned external IP address.

2. Create a TCPRoute to configure access to your worklad:

Expand All @@ -94,7 +94,7 @@ kubectl get crd gateways.gateway.networking.k8s.io &> /dev/null || \
EOF
```

### Send TCP Traffic to an TCPEcho Service
### Send TCP Traffic to a TCPEcho Service

1. Discover Istio Ingress Gateway's IP and port:

Expand Down