Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement image building in the kyma alpha app push command #2249

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

Cortey
Copy link
Contributor

@Cortey Cortey commented Nov 18, 2024

Description
As in title

Changes proposed in this pull request:

  • Build image from dockerfile
  • Support cross-platform build to run containers on Linux/amd64 architecture
  • Use the built image in created deployment

Related issue(s)
#2241

@Cortey Cortey added kind/feature Categorizes issue or PR as related to a new feature. area/cli Related to all activities around CLI labels Nov 18, 2024
@Cortey Cortey requested a review from a team as a code owner November 18, 2024 14:27
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2024
@pPrecel
Copy link
Contributor

pPrecel commented Nov 19, 2024

we've tested functionality using this Dockerfile:

FROM alpine:latest

WORKDIR /workspace

RUN apk update
RUN apk add go

COPY . /workspace

CMD [ "go", "run", "main.go", "--help", "&&", "sleep", "infinity" ]

and by running command:

go run main.go alpha app push --name test --dockerfile Dockerfile

@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 19, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 19, 2024
@pPrecel pPrecel merged commit 418585e into kyma-project:main Nov 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants