Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support skip health check option #1067

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

Yaiba
Copy link
Contributor

@Yaiba Yaiba commented Oct 16, 2024

  • a11fe98 supports a new client option SkipHealthcheck. If this option is set, errors from calling user.health API will be ignored, and fall back to user.chain_info to get ChainID.
  • a30c049 fix CI to build KGW together with kwil-db in workspace

Note: I push to kwilteam/kwil-db repo so I can manually trigger CI.

kwilteam/kgw#96 depends on this

@Yaiba
Copy link
Contributor Author

Yaiba commented Oct 16, 2024

manual KGW test on: current kwil-db branch , kgw kwilteam/kgw#96 , kwil-js main
https://github.com/kwilteam/kwil-db/actions/runs/11372858197

@Yaiba Yaiba force-pushed the feat/client-health-fallback-chaininfo branch from 6bd1681 to a30c049 Compare October 16, 2024 20:22
@Yaiba Yaiba marked this pull request as ready for review October 16, 2024 20:24
@Yaiba Yaiba requested a review from jchappelow October 21, 2024 18:57
@Yaiba Yaiba merged commit 62217d5 into main Oct 22, 2024
4 checks passed
@Yaiba Yaiba deleted the feat/client-health-fallback-chaininfo branch October 22, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants