You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Digging into the OnHeapSpillManager, I found the two spill buf implementations of File based and memory based. From my sight, maybe we could introduce the HybridSpillBuf to use the memory + file based bufs in one spill buf, which will make full use of memory for best effort.
Describe the solution you'd like
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered:
there is another path that when on-heap memory is almost full, spill.rs will create FileSpill instead of OnHeapSpill, which spills data directly to disk file. and FileBasedSpillBuf is only used when it is spilled by other non-native operators.
so i suggest we keep OnHeapSpillManager simpler and easier to be maintained.
there is another path that when on-heap memory is almost full, spill.rs will create FileSpill instead of OnHeapSpill, which spills data directly to disk file. and FileBasedSpillBuf is only used when it is spilled by other non-native operators. so i suggest we keep OnHeapSpillManager simpler and easier to be maintained.
Yes, gotten it. But if the onHeapSpill is activated on requiring from native side when on heap memory is enough, the path mentioned above will be used that the file spill is still used if on heap is not enough when using at that time. Anyway, I think this is just a corner case improvement, that may not achieve significant improvement for performance
Is your feature request related to a problem? Please describe.
Digging into the OnHeapSpillManager, I found the two spill buf implementations of File based and memory based. From my sight, maybe we could introduce the HybridSpillBuf to use the memory + file based bufs in one spill buf, which will make full use of memory for best effort.
Describe the solution you'd like
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: