Feature/7 interval initialization #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/adarshk7/intervals into feature/7-interval-initialization Conflicts: intervals/__init__.py
| @total_ordering | ||
| class AbstractInterval(object): | ||
| __metaclass__ = ClosedInterval |
There was a problem hiding this comment.
Does not work on Python 3.3. See http://pythonhosted.org/six/#six.with_metaclass
|
The Interval class constructor needs to be changed so that it supports also the following scenarios: IntInterval(2, 5, inc_upper=True) == IntInterval('(2, 5]']
IntInterval(2, 5, inc_lower=True) == IntInterval('[2, 5)']
IntInterval(2, 5, inc_lower=True, inc_upper=True) == IntInterval[2, 5] |
kvesteri
force-pushed
the
master
branch
2 times, most recently
from
d5ac267
to
e7512e2
Compare
kvesteri
force-pushed
the
master
branch
4 times, most recently
from
216a7b5
to
6cf3218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for interval initialization.
eg.
IntInterval(2, 5) == IntInterval((2, 5))
and
IntInterval[2, 5] == IntInterval([2, 5])