Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pipeline flow metrics #119

Merged
merged 1 commit into from
May 16, 2023
Merged

Add support for pipeline flow metrics #119

merged 1 commit into from
May 16, 2023

Conversation

kuskoman
Copy link
Owner

Closes #118

@kuskoman kuskoman requested a review from excalq May 16, 2023 13:46
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c13ee62) 100.00% compared to head (9c5243b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #119   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          513       536   +23     
=========================================
+ Hits           513       536   +23     
Impacted Files Coverage Δ
collectors/nodestats/pipeline_subcollector.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kuskoman kuskoman merged commit 7326fea into master May 16, 2023
@kuskoman kuskoman deleted the flow-metrics branch May 16, 2023 16:40
@excalq
Copy link
Contributor

excalq commented May 16, 2023

Flow metrics were added to Logstash 8.5.0. I'm still running 8.4, which lacks these. I'll test how this works with the source data missing, before upgrading our Logstash.

@kuskoman
Copy link
Owner Author

I did not think about it, thanks

@kuskoman
Copy link
Owner Author

It should default to 0 i think

@kuskoman
Copy link
Owner Author

#88 would be useful here I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for flow metrics
2 participants