Implement short.io

[empeje]

• In the options page, user can set their default URL shortener provider e.g. TinyURL, BitLy, and Short.io (Feature/short io provider #21)
• If the Short.io is chosen, the user should give their API Key. (Feature/short io provider #21)
• Additionally, in the options menu, they can set their default domain that we can get from this List Domain API (Feature/short io provider #21)
• In the main pop-up we will have a select box to choose the domain in addition to the textbox for the URL we want to shorten.
• When they click "shorten" we will use the Short.io API to shorten the domain. (Feature/short io provider #21)

[empeje]

Mas @yuliefas this will be our priority ya.

[empeje]

I received a notification that @wicaksana94 is asking the following question:

Is this will added by the user statically or dynamically?

@wicaksana94 could elaborate more on your question? Which part that you feel confused about?

[empeje]

mas @wicaksana94 if you want to take this, you can take parts that not already addressed in the #21

[wicaksana94]

Hy guys, do you try to build this project on Windows 10? I had little trouble on my own laptop (it's around "node -p") :

awica@DESKTOP-R9337DG MINGW64 /e/JS_LAB/ngecilin (master)
$ yarn build
yarn run v1.22.4
$ yarn clean && env VERSION=$(node -p "require('./package.json').version") npx webpack
$ rm -rf dist
env: ‘-p’: No such file or directory
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[wicaksana94]

I received a notification that @wicaksana94 is asking the following question:

Is this will added by the user statically or dynamically?

@wicaksana94 could elaborate more on your question? Which part that you feel confused about?

It's just the user interface layout, but now it's cleared by this commit from yuli efa suryantoro ( f6495a8 - Feature/short io provider (#21) )

[empeje]

Hy guys, do you try to build this project on Windows 10? I had little trouble on my own laptop (it's around "node -p") :

awica@DESKTOP-R9337DG MINGW64 /e/JS_LAB/ngecilin (master)
$ yarn build
yarn run v1.22.4
$ yarn clean && env VERSION=$(node -p "require('./package.json').version") npx webpack
$ rm -rf dist
env: ‘-p’: No such file or directory
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I think it is related to the node version, which node version you're using @wicaksana94?

[wicaksana94]

Hy guys, do you try to build this project on Windows 10? I had little trouble on my own laptop (it's around "node -p") :
awica@DESKTOP-R9337DG MINGW64 /e/JS_LAB/ngecilin (master)
$ yarn build
yarn run v1.22.4
$ yarn clean && env VERSION=$(node -p "require('./package.json').version") npx webpack
$ rm -rf dist
env: ‘-p’: No such file or directory
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I think it is related to the node version, which node version you're using @wicaksana94?
My node version is 10.16.3

[empeje]

Ah I think it is because the command using the $() is not working on windows, I guess we can create new build script for windows.

Technically the build should do the following

• Using version coming from package.json
• set the version to the environment variable
• run webpack

Could you create a new issue for this windows failed to build error?

Temporarily you can run npx webpack manually.

[wicaksana94]

Ah I think it is because the command using the $() is not working on windows, I guess we can create new build script for windows.

Technically the build should do the following

• Using version coming from package.json
• set the version to the environment variable
• run webpack

Could you create a new issue for this windows failed to build error?

Temporarily you can run npx webpack manually.

Ok, I did. #24