Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support DER certificates for kw.crypto.verifyCert() function #23

Open
viccuad opened this issue Feb 20, 2024 · 0 comments
Labels
kind/enhancement New feature or request

Comments

@viccuad
Copy link
Member

viccuad commented Feb 20, 2024

Currently, only PEM certificates are accepted in kw.crypto.verifyCert() CEL function.

Acceptance criteria

  • Expand the library to also accept DER certificates. This can be done by overloading the kw.crypto.verifyCert() function.
  • The go sdk expects `crypto.Certificate{} struct for both the certificate to be verified and the certificate chain to verify against. This Certificate has an enum field (PEM, DER) and accepts []bytes. Register the corresponding int constants for the enum, and do the casting to []bytes correctly.
  • Ensure that both types of encoding for the certificates can be used interchangeably.
  • Provide unit tests.
  • Provide e2e tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant