Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor recording rules and alerts code #870

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Refactor recording rules and alerts code #870

merged 1 commit into from
Feb 15, 2024

Conversation

avlitman
Copy link
Contributor

@avlitman avlitman commented Feb 1, 2024 •
edited
Loading

What this PR does / why we need it:
Following the work started in kubevirt/kubevirt#10044 , and according to the kubevirt/community#219 proposal, this PR refactors monitoring recording rules and alerts

Which issue(s) this PR fixes:

Fixes #
jira-tickEt: https://issues.redhat.com/browse/CNV-37376
jira-ticket: https://issues.redhat.com/browse/CNV-34290
Special notes for your reviewer:

Release note:

Refactor recording-rules and alerts code.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 1, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@avlitman avlitman changed the title refactor recording rules and alerts code [wip] refactor recording rules and alerts code Feb 1, 2024
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

/cc sradco

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

/cc sradco

@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

/cc sradco

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

/cc sradco

@avlitman avlitman marked this pull request as ready for review February 7, 2024 11:20
@avlitman avlitman changed the title [wip] refactor recording rules and alerts code Refactor recording rules and alerts code Feb 7, 2024
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2024
@avlitman
Copy link
Contributor Author

avlitman commented Feb 7, 2024

This ci is flaky and passed manually: Test csv-generator

@avlitman
Copy link
Contributor Author

avlitman commented Feb 7, 2024

/retest

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2024
akrejcir
akrejcir reviewed Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@akrejcir akrejcir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please add more text to the commit message?

internal/template-validator/validator/app.go Show resolved Hide resolved
pkg/monitoring/rules/alerts/prometheus.go Outdated Show resolved Hide resolved
pkg/monitoring/rules/alerts/prometheus.go Outdated Show resolved Hide resolved
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2024
@avlitman avlitman force-pushed the refactor-rules-code branch 2 times, most recently from 8eaada4 to 67be6bf Compare February 13, 2024 10:21
0xFelix
0xFelix reviewed Feb 13, 2024
View reviewed changes
main.go Outdated Show resolved Hide resolved
pkg/monitoring/rules/recordingrules/operator.go Show resolved Hide resolved
@akrejcir
Copy link
Collaborator

/retest

akrejcir
akrejcir reviewed Feb 13, 2024
View reviewed changes
main.go Show resolved Hide resolved
@avlitman
Copy link
Contributor Author

/retest

@avlitman
refactor recording rules and alerts code
4fd4022 
Following the work started in kubevirt/kubevirt#10044 , and according to
the kubevirt/community#219 proposal, this PR refactors monitoring
recording rules and alerts

Signed-off-by: avlitman <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
16.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@avlitman
Copy link
Contributor Author

/retest

@akrejcir
Copy link
Collaborator

Thanks!

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@machadovilaca
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@kubevirt-bot kubevirt-bot merged commit 3667571 into kubevirt:main Feb 15, 2024
12 checks passed
@machadovilaca machadovilaca mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksimon1 ksimon1 Awaiting requested review from ksimon1

@sradco sradco Awaiting requested review from sradco

@machadovilaca machadovilaca Awaiting requested review from machadovilaca

@0xFelix 0xFelix Awaiting requested review from 0xFelix

@akrejcir akrejcir Awaiting requested review from akrejcir

@codingben codingben Awaiting requested review from codingben

Assignees

@machadovilaca machadovilaca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@avlitman @codingben @akrejcir @kubevirt-bot @machadovilaca @0xFelix