Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable end-to-end validator tests on s390x. #1143

Conversation

nestoracunablanco
Copy link
Contributor

What this PR does / why we need it: s390x enablement

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 25, 2024
tests/monitoring_test.go Outdated Show resolved Hide resolved
tests/validator_test.go Outdated Show resolved Hide resolved
@nestoracunablanco
Copy link
Contributor Author

/retest

@nestoracunablanco nestoracunablanco force-pushed the test/s390xValidationTestsEnablement branch from 66223d4 to f206989 Compare November 26, 2024 08:45
tests/validator_test.go Outdated Show resolved Hide resolved
@nestoracunablanco nestoracunablanco force-pushed the test/s390xValidationTestsEnablement branch from f206989 to 1502780 Compare November 26, 2024 10:25
tests/validator_test.go Outdated Show resolved Hide resolved
tests/tests_suite_test.go Outdated Show resolved Hide resolved
@akrejcir
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
tests/tests_suite_test.go Outdated Show resolved Hide resolved
@nestoracunablanco
Copy link
Contributor Author

/retest

@nestoracunablanco nestoracunablanco force-pushed the test/s390xValidationTestsEnablement branch from c440aeb to 5d9489e Compare November 26, 2024 18:51
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@nestoracunablanco
Copy link
Contributor Author

/retest

1 similar comment
@nestoracunablanco
Copy link
Contributor Author

/retest

@akrejcir
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2024
@nestoracunablanco
Copy link
Contributor Author

/retest

@kubevirt-bot kubevirt-bot merged commit d5b7de7 into kubevirt:main Nov 28, 2024
12 checks passed
@nestoracunablanco nestoracunablanco deleted the test/s390xValidationTestsEnablement branch November 28, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants