-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert the vm.sh script into a go binary #1160
Comments
Hi! I'd like to tackle this issue. For this, do we need to move the logic of this script into cluster-provision/gocli? /assign |
@Kuruyia I'd simply create a new binary and replace the vm.sh with it. Writing a cli tool in bash isn't the nicest thing |
Hey @alicefr, I just opened a PR for this issue: #1164 :) I tested this new CLI manually with the steps described in the KUBEVIRTCI_LOCAL_TESTING.md file and I got a cluster up and running. I'd love to have your input on how to further test this (automatically) and integrate it with the project so we can start using it. |
@anishbista60 there is already an open PR which already address this issue: #1164 |
That PR should be ready for merging if there are no more reviews btw @alicefr |
@Kuruyia the PR looked already very good to me, I was waiting for @brianmcarey and @dhiller to understand how to integrate it smoothly in the new provider. At least for a release, I would keep the script and the binary in order to be able to roll back if there are any issues. @brianmcarey @dhiller would you be able to review the PR? |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. /close |
@kubevirt-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/remove-lifecycle rotten |
/reopen |
@dhiller: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Is your feature request related to a problem? Please describe:
Create a go cli that replaces the vm.sh script.
The text was updated successfully, but these errors were encountered: