Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use bitnami charts as dependencies #28

Open
christianhuth opened this issue May 16, 2022 · 8 comments
Open

use bitnami charts as dependencies #28

christianhuth opened this issue May 16, 2022 · 8 comments
Labels
good first issue Good for newcomers

Comments

@christianhuth
Copy link
Contributor

Suggestion for improvement and simplification

Instead of defining MySQL and Redis "charts" as subcharts just use existing charts from Bitnami:

@rubenhak rubenhak transferred this issue from kubevious/helm May 17, 2022
@rubenhak rubenhak added the good first issue Good for newcomers label May 17, 2022
@rubenhak
Copy link
Collaborator

Thanks for reporting. Would it be possible to update the chart to use MySQL subchart preserving the PVC that holds data?

@christianhuth
Copy link
Contributor Author

@rubenhak there is an option in values.yaml to use an existing PVC: https://artifacthub.io/packages/helm/bitnami/mysql?modal=values&path=primary.persistence.existingClaim. So it should be possible if the used MySQL versions are the same.

@rubenhak
Copy link
Collaborator

rubenhak commented Jul 8, 2022

@christianknell, thanks, that's a good finding! Do you know if the volumes would be compatible between mysql and bitnami/mysql images?

@christianknell, @tanmay-bhat, do you think we can get some community help to use dependent subcharts for mysql and redis?

@christianhuth
Copy link
Contributor Author

@rubenhak the Bitnami charts are run as non-root user. So i think the PVC can't be used right away because the file permissions wouldn't match. But the Bitnami charts come with an option to set these file permissions on initialization: https://artifacthub.io/packages/helm/bitnami/mysql?modal=values&path=volumePermissions.
So from my perspective they should be compatible, but i haven't tried this so far.

If you decide to switch to the Bitnami charts i can help you with development. See https://github.com/christianknell/helm-charts/tree/main/charts/shlink-backend for an example on how to define the dependencies and use the values in your own chart.

@rubenhak
Copy link
Collaborator

@christianknell, I guess we can compromise one time upgradability to use Bitnami sub-charts.

A help would be awesome! I looked through the chart definition, could see the chart dependency and the "mysql.enabled" flag, but couldn't see how other mysql variables are passed to the chart. Can you show how this would work with subcharts?

@christianhuth
Copy link
Contributor Author

@rubenhak: i will have a try to use an existing pvc, when i start the transition to the Bitnami sub-charts.

Sub-charts are defined through "an extra hierachy" in your values.yaml. You can see in this example values.yaml the key mysql which takes the values for the mysql sub-chart. This works the same way with every sub-chart in Helm. See also this description in the documentation.

@christianhuth
Copy link
Contributor Author

@rubenhak: I would try to migrate to the Bitnami charts between Christmas and new year's eve. Could you move this issue to the new helm repository please?

@kubevious kubevious transferred this issue from kubevious/kubevious Dec 24, 2022
@rubenhak
Copy link
Collaborator

@christianknell, Done. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants