Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review examples with agents and add extra_hosts for make them work on Linux #3395

Closed
mathnogueira opened this issue Nov 23, 2023 · 1 comment
Closed

review examples with agents and add extra_hosts for make them work on Linux #3395

mathnogueira opened this issue Nov 23, 2023 · 1 comment
Assignees
@mathnogueira
Labels
bug Something isn't working enhancement New feature or request

Comments

@mathnogueira
Copy link
Contributor

Describe the enhancement you'd like to see
#3393 pointed out that our pokeshop example with the agent was failing on Linux. We have to review all examples that rely on the agent to make sure they work on Linux.
@mathnogueira mathnogueira added bug Something isn't working enhancement New feature or request labels Nov 23, 2023
@mathnogueira mathnogueira self-assigned this Nov 23, 2023
@mathnogueira
Copy link
Contributor Author

I reviewed all agent examples we have right now and the one using pokeshop was the only one that relied on an agent running outside docker and collecting spans. So after #3394 was merged, there were no more examples to be patched. I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathnogueira mathnogueira

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mathnogueira