Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: official Helm chart doesn't allow to pass custom NATS #4848

Open
rangoo94 opened this issue Jan 2, 2024 · 0 comments
Open

Bug: official Helm chart doesn't allow to pass custom NATS #4848

rangoo94 opened this issue Jan 2, 2024 · 0 comments
Assignees
Labels
bug 🐛 Something is not working as should be helm-charts 🪖

Comments

@rangoo94
Copy link
Member

rangoo94 commented Jan 2, 2024

Describe the bug

The Helm chart decides to include the NATS based on testkube-api.nats.enabled.

If someone wants to use external NATS service, there are 2 options now:

  • Pass testkube-api.nats.secretName and testkube-api.nats.secretKey for the expected NATS service and keep testkube-api.nats.enabled: true
    • There will be still running NATS container, just unused
  • Option 1, but with own Helm chart to avoid deploying unused NATS container

Expected behavior

  • There should be an option to avoid NATS service, while still passing proper NATS credentials
  • Optionally: there could be an option to pass NATS URI in plain text (like testkube-api.nats.uri)
@rangoo94 rangoo94 added the bug 🐛 Something is not working as should be label Jan 2, 2024
@rangoo94 rangoo94 assigned rangoo94 and unassigned ypoplavs Jan 2, 2024
rangoo94 added a commit to kubeshop/helm-charts that referenced this issue Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something is not working as should be helm-charts 🪖
Projects
None yet
Development

No branches or pull requests

2 participants