Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to define resources for miscellaneous addons #16735

Open
elliotdobson opened this issue Aug 5, 2024 · 1 comment
Open

Allow to define resources for miscellaneous addons #16735

elliotdobson opened this issue Aug 5, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@elliotdobson
Copy link
Contributor

/kind feature

1. Describe IN DETAIL the feature/behavior/change you would like to see.

You are able to specify custom resources on most Kubernetes controllers now in kOps (eg. kubeAPIServer, kubeControllerManager, kubeDNS, kubeProxy, kubeScheduler & etcdClusters).

I'd also like to be able to specify custom resources for any addons that are enabled. Some do already support it like cluster-autoscaler however it is not consistent across them.

Specifically I'd like to see support added for:

  • aws-cloud-controller-manager
  • calico-kube-controllers & calico-node
  • cert-manager, cert-manager-cainjector & cert-manager-webhook
  • ebs-csi-controller & ebs-csi-node
  • pod-identity-webhook

I'm happy to implement if maintainers agree with adding this feature.

2. Feel free to provide a design supporting your feature request.

There seems to be an existing pattern for including custom resources in the kOps API:

	// CPURequest, cpu request compute resource for kube-controler-manager. Defaults to "100m"
	CPURequest *resource.Quantity `json:"cpuRequest,omitempty"`
	// CPULimit, cpu limit compute resource for kube-controler-manager e.g. "500m"
	CPULimit *resource.Quantity `json:"cpuLimit,omitempty"`
	// MemoryRequest, memory request compute resource for kube-controler-manager e.g. "30Mi"
	MemoryRequest *resource.Quantity `json:"memoryRequest,omitempty"`
	// MemoryLimit, memory limit compute resource for kube-controler-manager e.g. "30Mi"
	MemoryLimit *resource.Quantity `json:"memoryLimit,omitempty"`
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 5, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants