Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to differentiate specific hypervisors on s390x #2037

Open
routerhan opened this issue Jan 29, 2025 · 1 comment
Open

Add support to differentiate specific hypervisors on s390x #2037

routerhan opened this issue Jan 29, 2025 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@routerhan
Copy link

What would you like to be added:

Add support to differentiate hypervisors on s390x nodes. While the existing HYPERVISOR label works for KVM, it does not identify z/VM as virtual machine. Using tools like lscpu, this feature would add finer-grained labels for hypervisors such as z/VM and PR/SM (LPAR).

lscpu ouput for z/VM:

# lscpu
[...]
Virtualization features:
  Hypervisor:             z/VM 7.2.0
  Hypervisor vendor:      IBM
  Virtualization type:    full
[...]

# lscpu --json | \
  jq -r '.lscpu[] | select(.field == "Hypervisor:") | .data'
z/VM 7.2.0

Why is this needed:

The current HYPERVISOR label is insufficient for s390x nodes, as it only identifies KVM. Differentiating z/VM and LPAR is essential for accurate workload scheduling and operational requirements in s390x environments.

@routerhan routerhan added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 29, 2025
@marquiz
Copy link
Contributor

marquiz commented Jan 30, 2025

@routerhan thank you for the suggestion. We can't use lscpu in nfd.

On X86 that we'd get the information from the cpuid library (just missing the label in nfd):
https://github.com/klauspost/cpuid/blob/78c3c03144afe88fbedab38757e27cb1537a3418/cpuid.go#L314

Would you be willing to contribute this feature? IIRC the cpuid library does not have s390 features (yet), so (if you're not willing to contribute to cpuid) we could add the s390 support directly to nfd. Ref:
https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/source/cpu/cpuid_linux_s390x.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants