Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ingresses-only flag #67

Open
LiorLieberman opened this issue Sep 24, 2023 · 9 comments
Open

Add a ingresses-only flag #67

LiorLieberman opened this issue Sep 24, 2023 · 9 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@LiorLieberman
Copy link
Member

LiorLieberman commented Sep 24, 2023

What would you like to be added:
Add a ingresses-only flag to scope the tool to only convert resources without looking for providers CRDs

Why this is needed:
Provider specific support is in early stage support now with only few providers support the conversion. Users might want to scope the tool invocation to only read and convert their ingresses

/good-first-issue
/help-wanted

@LiorLieberman LiorLieberman added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 24, 2023
@k8s-ci-robot
Copy link
Contributor

@LiorLieberman: The label(s) /label good-first-issue cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

What would you like to be added:
Add a ingresses-only flag to scope the tool to only convert resources without looking for providers CRDs

Why this is needed:
Provider specific support is in early stage support now with only few providers support the conversion. Users might want to scope the tool invocation to only read and convert their ingresses

/label good-first-issue
/help-wanted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LiorLieberman LiorLieberman added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 24, 2023
@camperjett
Copy link

Hi! Can I take up this issue? I'll be glad to help

@levikobi
Copy link
Member

Hi @camperjett! Sure, thanks!
Let us know if you have any questions or if you need any help

/assign @camperjett

@camperjett
Copy link

Hi! I have made the required changes to cmd/print.go file. How do I test it?

@levikobi
Copy link
Member

@camperjett, the first thing you'll want to do is make sure existing unit tests are passing. After that, you can build the binary and use the tool with the new flag you added.
You should use ingress manifest files that contain ingress-nginx-related headers (such as canary headers). See if those headers are translated without specifying your flag and if they are not translated when using it.

I think this can be a good place to start with

@camperjett
Copy link

camperjett commented Sep 28, 2023

How do I use the tool? I am totally new to CNCF eco-system

@levikobi
Copy link
Member

You can use the make build target to build it.
Then, I recommend you start playing around with it. Take a look at https://github.com/kubernetes-sigs/ingress2gateway#usage for some details.

@prakrit55
Copy link

@camperjett are you still working on it, I would like to give it a try 🙂

@mlavacca
Copy link
Member

Since we have multiple providers on board now, I'm not sure this is still something we may want to implement. What do you think, @LiorLieberman?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
6 participants