-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ami): Support Amazon Linux 2023 #1640
base: main
Are you sure you want to change the base?
Conversation
Hi @phuhung273. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi team, i tried to run e2e node conformance test https://image-builder.sigs.k8s.io/capi/providers/aws#testing-images but the doc is outdated. I think we need to have another separate Issue for it. |
/ok-to-test |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@drew-viles @richardcase please take a look if you can.
Thanks for doing this work @phuhung273!
@@ -27,15 +27,6 @@ | |||
- ansible_os_family == "RedHat" | |||
- ansible_distribution != "Amazon" | |||
|
|||
- name: Install aws agents RPM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still want to install this on Amazon Linux 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved them here
image-builder/images/capi/ansible/roles/node/defaults/main.yml
Lines 32 to 33 in 4491b30
- amazon-ssm-agent | |
- awscli |
/hold @phuhung273 could you squash the commits? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for your review @mboersma. I just squashed but now whole CI is rerunning :( If there is a way to squash without affecting CI, would be great |
/retest |
/lgtm |
Change description
Related issues
GOSS log