Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up e2e tests by increasing concurrency / # of ginkgo nodes #9579

Closed
sbueringer opened this issue Oct 19, 2023 · 5 comments · Fixed by #11067
Closed

Speed up e2e tests by increasing concurrency / # of ginkgo nodes #9579

sbueringer opened this issue Oct 19, 2023 · 5 comments · Fixed by #11067
Assignees
@sbueringer
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sbueringer
Copy link
Member

sbueringer commented Oct 19, 2023 •
edited
Loading

This issue is about running our e2e tests with more ginkgo nodes / concurrency instead of 3.

I think this would improve our dev efficiency because we end up with a quicker feedback loop for e2e-full. It also allows us to add more e2e tests without being too worried about test durations.

For context: Slack: https://kubernetes.slack.com/archives/C8TSNPY4T/p1697730320651299
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 19, 2023
@sbueringer sbueringer mentioned this issue Oct 19, 2023
Closed
@sbueringer
Copy link
Member Author

cc @kubernetes-sigs/cluster-api-release-team

I'll open the PR for release-1.4. Happy if someone wants to take over the rest of the issue

@sbueringer sbueringer mentioned this issue Oct 19, 2023
Closed
@killianmuldoon
Copy link
Contributor

Thanks!

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 19, 2023
@sbueringer
Copy link
Member Author

sbueringer commented Oct 19, 2023 •
edited
Loading

To also mention it here. I think we can see 10 as an intermediate step to gather more experience with higher concurrency.

Once we moved all jobs to the EKS cluster, we can figure out what node size they are using, use higher CPU request/limits and further increase our concurrency

@sbueringer sbueringer changed the title Speed up e2e tests by running with 10 ginkgo nodes instead of 3 Speed up e2e tests by increasing concurrency / # of ginkgo nodes Oct 19, 2023
@sbueringer sbueringer self-assigned this Oct 26, 2023
@sbueringer
Copy link
Member Author

sbueringer commented Oct 26, 2023 •
edited
Loading

Given that the tests were not really stable with concurrency 10. I'll wait until after the EKS move. Possible next steps then:

  • Increase job resources to 14 cores => re-run the tests

@fabriziopandini
Copy link
Member

/kind feature
/priority backlog

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Apr 11, 2024
@sbueringer sbueringer mentioned this issue Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbueringer sbueringer

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 test/e2e: increase concurrency sbueringer/cluster-api
4 participants
@sbueringer @fabriziopandini @k8s-ci-robot @killianmuldoon