Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fetching Power VS network with regular expression #1994

Open
Karthik-K-N opened this issue Oct 7, 2024 · 6 comments
Open

Support fetching Power VS network with regular expression #1994

Karthik-K-N opened this issue Oct 7, 2024 · 6 comments
Assignees
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@Karthik-K-N
Copy link
Contributor

/kind feature
/area provider/ibmcloud

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

A Power VS network can be identified by id, name or regular expression, Currently we support both id and name. I would like to have support for fetching network by regular expression.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Oct 7, 2024
@Karthik-K-N
Copy link
Contributor Author

In openshift we mainly use regular expression for identifying a network for reference in machine spec

      network:
        regex: ^DHCPSERVER.*ipi-sa04-418nig-jqw97.*_Private$
        type: RegEx
      processorType: Shared
      processors: "0.5"

for feature parity I would like to have same support in CAPIBM as well.

@Karthik-K-N
Copy link
Contributor Author

When only spec.network.regex is set and no other network resources are set the controller will create the DHCP server and corresponding network of format DHCPSERVER<dhcp_server_name>_Private,

so we may need to webhook validation to let user know that when setting regular expression make sure it matches either DHCP server name when set or cluster_name when dhcp server details are not set.

@Karthik-K-N
Copy link
Contributor Author

/cc @Amulyam24

@Karthik-K-N
Copy link
Contributor Author

For reference we already support regex matching for machines

@Karthik-K-N Karthik-K-N changed the title Support fetchingn Power VS network with regular expression Support fetching Power VS network with regular expression Oct 8, 2024
@Amulyam24
Copy link
Contributor

/assign

@Amulyam24 Amulyam24 removed their assignment Oct 18, 2024
@carmal891
Copy link
Contributor

/assign

@mkumatag mkumatag added this to the Next milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants