Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bump CAPI to v1.9.2 #5316

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Dec 2, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates CAPI to v1.9.2.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

See controller-runtime v0.19 release notes: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.19.0
See CAPI 1.8 - 1.9 migration guide: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.8-to-v1.9.md
CAPA's PR, for comparison: kubernetes-sigs/cluster-api-provider-aws#5209

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Bump CAPI to v1.9.2

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mboersma. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma
Copy link
Contributor Author

mboersma commented Dec 2, 2024

/test pull-cluster-api-provider-azure-ci-entrypoint

@mboersma mboersma changed the title Bump CAPI to v1.9.0-rc.0 [WIP] Bump CAPI to v1.9.0-rc.0 Dec 2, 2024
@mboersma mboersma mentioned this pull request Dec 2, 2024
4 tasks
@mboersma
Copy link
Contributor Author

mboersma commented Dec 2, 2024

/test pull-cluster-api-provider-azure-ci-entrypoint

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 35.89744% with 50 lines in your changes missing coverage. Please review.

Project coverage is 52.42%. Comparing base (87feabd) to head (afe23d0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
main.go 0.00% 18 Missing ⚠️
controllers/asosecret_controller.go 0.00% 5 Missing ⚠️
...ntrollers/azureasomanagedmachinepool_controller.go 0.00% 5 Missing ⚠️
controllers/azureasomanagedcluster_controller.go 0.00% 4 Missing ⚠️
...trollers/azureasomanagedcontrolplane_controller.go 0.00% 3 Missing ⚠️
controllers/azurejson_machine_controller.go 0.00% 3 Missing ⚠️
controllers/azurejson_machinepool_controller.go 0.00% 3 Missing ⚠️
...ontrollers/azurejson_machinetemplate_controller.go 0.00% 3 Missing ⚠️
azure/scope/machine.go 0.00% 1 Missing ⚠️
azure/scope/machinepool.go 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5316      +/-   ##
==========================================
- Coverage   52.43%   52.42%   -0.02%     
==========================================
  Files         272      272              
  Lines       29401    29407       +6     
==========================================
- Hits        15417    15416       -1     
- Misses      13178    13185       +7     
  Partials      806      806              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mboersma
Copy link
Contributor Author

mboersma commented Dec 2, 2024

/test pull-cluster-api-provider-azure-ci-entrypoint

1 similar comment
@mboersma
Copy link
Contributor Author

mboersma commented Dec 2, 2024

/test pull-cluster-api-provider-azure-ci-entrypoint

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 2, 2024
@mboersma mboersma force-pushed the bump-capi-one-nine-zero branch 2 times, most recently from 52803fb to 571ecf0 Compare December 2, 2024 20:30
@mboersma
Copy link
Contributor Author

mboersma commented Dec 2, 2024

/test pull-cluster-api-provider-azure-ci-entrypoint
/test pull-cluster-api-provider-azure-verify

@mboersma mboersma marked this pull request as ready for review December 2, 2024 20:48
@@ -921,20 +915,20 @@ spec:
description: |-
The reason for the condition's last transition in CamelCase.
The specific API may choose whether or not this field is considered a guaranteed API.
This field may not be empty.
This field may be empty.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why the new controller-gen is making this type of change.

@mboersma mboersma force-pushed the bump-capi-one-nine-zero branch from 571ecf0 to 2b9c390 Compare December 5, 2024 16:13
@mboersma mboersma changed the title [WIP] Bump CAPI to v1.9.0-rc.0 [WIP] Bump CAPI to v1.9.0-rc.1 Dec 5, 2024
@mboersma mboersma force-pushed the bump-capi-one-nine-zero branch 2 times, most recently from 85b1e57 to 0469276 Compare December 10, 2024 19:49
@mboersma mboersma force-pushed the bump-capi-one-nine-zero branch from 0469276 to 3cd8220 Compare December 11, 2024 16:24
@mboersma
Copy link
Contributor Author

/retitle [WIP] Bump CAPI to v1.9.0

@k8s-ci-robot k8s-ci-robot changed the title [WIP] Bump CAPI to v1.9.0-rc.1 [WIP] Bump CAPI to v1.9.0 Dec 11, 2024
@willie-yao willie-yao linked an issue Dec 13, 2024 that may be closed by this pull request
@mboersma mboersma force-pushed the bump-capi-one-nine-zero branch from 3cd8220 to bdd1f8e Compare December 20, 2024 17:55
@mboersma mboersma changed the title [WIP] Bump CAPI to v1.9.0 [WIP] Bump CAPI to v1.9.2 Dec 20, 2024
@mboersma mboersma force-pushed the bump-capi-one-nine-zero branch from bdd1f8e to 986debd Compare December 20, 2024 17:58
@k8s-ci-robot
Copy link
Contributor

@mboersma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-apiversion-upgrade 3cd8220 link true /test pull-cluster-api-provider-azure-apiversion-upgrade
pull-cluster-api-provider-azure-apidiff afe23d0 link false /test pull-cluster-api-provider-azure-apidiff
pull-cluster-api-provider-azure-e2e afe23d0 link true /test pull-cluster-api-provider-azure-e2e
pull-cluster-api-provider-azure-e2e-aks afe23d0 link true /test pull-cluster-api-provider-azure-e2e-aks
pull-cluster-api-provider-azure-capi-e2e afe23d0 link false /test pull-cluster-api-provider-azure-capi-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

CAPI v1.9.0-beta.0 has been released and is ready for testing
2 participants