-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Bump CAPI to v1.9.2 #5316
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-cluster-api-provider-azure-ci-entrypoint |
/test pull-cluster-api-provider-azure-ci-entrypoint |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5316 +/- ##
==========================================
- Coverage 52.43% 52.42% -0.02%
==========================================
Files 272 272
Lines 29401 29407 +6
==========================================
- Hits 15417 15416 -1
- Misses 13178 13185 +7
Partials 806 806 ☔ View full report in Codecov by Sentry. |
/test pull-cluster-api-provider-azure-ci-entrypoint |
1 similar comment
/test pull-cluster-api-provider-azure-ci-entrypoint |
52803fb
to
571ecf0
Compare
/test pull-cluster-api-provider-azure-ci-entrypoint |
@@ -921,20 +915,20 @@ spec: | |||
description: |- | |||
The reason for the condition's last transition in CamelCase. | |||
The specific API may choose whether or not this field is considered a guaranteed API. | |||
This field may not be empty. | |||
This field may be empty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why the new controller-gen is making this type of change.
571ecf0
to
2b9c390
Compare
85b1e57
to
0469276
Compare
0469276
to
3cd8220
Compare
/retitle [WIP] Bump CAPI to v1.9.0 |
3cd8220
to
bdd1f8e
Compare
bdd1f8e
to
986debd
Compare
@mboersma: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates CAPI to v1.9.2.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
See controller-runtime v0.19 release notes: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.19.0
See CAPI 1.8 - 1.9 migration guide: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.8-to-v1.9.md
CAPA's PR, for comparison: kubernetes-sigs/cluster-api-provider-aws#5209
TODOs:
Release note: