-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ut #4789
Open
bobz965
wants to merge
3
commits into
kubeovn:master
Choose a base branch
from
bobz965:fix-ut
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix ut #4789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bobz965 <[email protected]>
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
test
automation tests
labels
Dec 4, 2024
Signed-off-by: bobz965 <[email protected]>
Pull Request Test Coverage Report for Build 12157403622Details
💛 - Coveralls |
GetAllChassisByHost() 和 GetChassisByHost() 除了返回值不同外,有什么区别吗? |
如果是 t.Cleanup() 提前执行导致的,为什么日志里只有删除前三个 chassis 的记录?
|
有空了修改下调用的 require 函数吧,一旦 ut 失败,拿不到有效的信息。 |
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:M
This PR changes 30-99 lines, ignoring generated files.
labels
Dec 5, 2024
删了 GetAllChassisByHost |
Signed-off-by: bobz965 <[email protected]>
使用 require.Contains ,我后续改一下吧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
该 ut 创建的资源是唯一的,感觉像是提前删除了资源
Which issue(s) this PR fixes
Fixes #(issue-number)