Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): expose existing_token client property #11400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(cli): expose existing_token client property #11400

wants to merge 1 commit into from
+7 −3

Conversation

tumido
Copy link

@tumido tumido commented Nov 22, 2024

Description of your changes:

This PR exposes existing_token option of kfp.Client to the CLI.

Resolves: #11399

Checklist:

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign connor-mccarthy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tumido tumido mentioned this pull request Nov 22, 2024
Open
@google-oss-prow Google OSS Prow
Copy link

Hi @tumido. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hbelmiro
hbelmiro reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@google-oss-prow google-oss-prow bot added the lgtm label Nov 22, 2024
@tumido
Copy link
Author

tumido commented Nov 22, 2024

@hbelmiro can you please approve the CI to be run on this? It seems ok-to-test is not enough and some additional button clicking or keyboard smashing is still required. 🤷‍♂️ 🙂

DharmitD
DharmitD reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HumairAK could you approve the CI runs for this PR? Otherwise,
/lgtm

@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DharmitD DharmitD DharmitD left review comments

@hbelmiro hbelmiro hbelmiro left review comments

@gregsheremeta gregsheremeta Awaiting requested review from gregsheremeta

Assignees

@hbelmiro hbelmiro

@DharmitD DharmitD

Labels
ci-passed All CI tests on a pull request have passed lgtm ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Expose existing_token in KFP CLI
3 participants
@tumido @hbelmiro @DharmitD