Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Show current status of daemonset in karmor install #450

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Manik2708
Copy link
Contributor

Fixes: #443
This change will now show the status of pods. The only doubt is what to do in Pending state of pod? Currently it will wait for the pod to be Running or Failed. If Pod is running but container is not (due to CrashLoopBackOff or something else) it will mark pod as not running and show the reason and break the loop! Please see this for reference:

Screenshot from 2024-07-24 22-57-47

Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
@daemon1024
Copy link
Member

Thanks for the quick PR. There's no point of having the Verifiying logic run if the pod is in CrashLoopBackOff. We should skip that check if the Pod is not running

Signed-off-by: Manik2708 <[email protected]>
@Manik2708
Copy link
Contributor Author

Thanks for the quick PR. There's no point of having the Verifiying logic run if the pod is in CrashLoopBackOff. We should skip that check if the Pod is not running

Done!

Screenshot from 2024-07-25 14-38-02

@Aryan-sharma11
Copy link
Member

Thanks for the quick PR. There's no point of having the Verifiying logic run if the pod is in CrashLoopBackOff. We should skip that check if the Pod is not running

Done!

Screenshot from 2024-07-25 14-38-02

The output should be something like in following order
if pod.status == runinng {
print(" verifying kubearmor functionality")
} else {
print(" failed to verify kubearmor functionality, kubearmor daemonset failed to start" , pod. status.reason)
}
cc: @daemon1024

Signed-off-by: Manik2708 <[email protected]>
@Manik2708
Copy link
Contributor Author

Thanks for the quick PR. There's no point of having the Verifiying logic run if the pod is in CrashLoopBackOff. We should skip that check if the Pod is not running

Done!
Screenshot from 2024-07-25 14-38-02

The output should be something like in following order if pod.status == runinng { print(" verifying kubearmor functionality") } else { print(" failed to verify kubearmor functionality, kubearmor daemonset failed to start" , pod. status.reason) } cc: @daemon1024

Resolved!

@Manik2708
Copy link
Contributor Author

@daemon1024 Please review

@Manik2708
Copy link
Contributor Author

@daemon1024 @Aryan-sharma11 Please review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show current status of daemonset in karmor install
3 participants