-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Show current status of daemonset in karmor install #450
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
Thanks for the quick PR. There's no point of having the Verifiying logic run if the pod is in CrashLoopBackOff. We should skip that check if the Pod is not running |
Signed-off-by: Manik2708 <[email protected]>
The output should be something like in following order |
Signed-off-by: Manik2708 <[email protected]>
Resolved! |
@daemon1024 Please review |
@daemon1024 @Aryan-sharma11 Please review! |
Fixes: #443
This change will now show the status of pods. The only doubt is what to do in
Pending
state of pod? Currently it will wait for the pod to beRunning
orFailed
. If Pod is running but container is not (due toCrashLoopBackOff
or something else) it will mark pod as not running and show the reason and break the loop! Please see this for reference: