Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karmor sysdump: generated .*apparmor.tar.gz is not actually a gzip tar #458

Closed
DelusionalOptimist opened this issue Aug 27, 2024 · 1 comment
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@DelusionalOptimist
Copy link
Member

Description

karmor sysdump generates some data for debugging which also includes all the generated AppArmor profiles.
The entire /etc/apparmor.d directory is converted to tar and dumped with the extension .tar.gz however it is not gzipped.

Ref - https://github.com/kubearmor/kubearmor-client/blob/main/sysdump/sysdump.go#L252

Possible Solution

Make it a gzip or change the file extension.
Additional refactor can be done as well to make the function a little generic.

@DelusionalOptimist DelusionalOptimist added good first issue Good for newcomers help wanted Extra attention is needed bug Something isn't working labels Aug 27, 2024
@rissh
Copy link
Contributor

rissh commented Aug 27, 2024

Hey @DelusionalOptimist ,

I want to give it a try and work on this issue. Can you please assign me this issue?
Please feel free to give me any suggestions or guidance as I work on this task. I'm open to feedback and would appreciate any insights you have.

Thank you!

Aryan-sharma11 added a commit that referenced this issue Dec 5, 2024
[#458] fix(sysdump): ensure AppArmor tar is gzipped in sysdump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants