Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Improving Broken-link-check scope #369

Open
rootxrishabh opened this issue Sep 4, 2023 · 3 comments
Open

[feat] Improving Broken-link-check scope #369

rootxrishabh opened this issue Sep 4, 2023 · 3 comments

Comments

@rootxrishabh
Copy link
Member

This action does not seem to be working, It looks like the scope of the action that has to be redefined.

@rootxrishabh
Copy link
Member Author

@daemon1024 can you advise?

@kranurag7
Copy link
Member

Hey @rootxrishabh I think the action is working fine, please have a look at this page https://github.com/kubearmor/kubearmor-client/actions/workflows/broken-link-check.yml

Do you have any example of this action not working?
As of now, it's running whenever renovate bot pushes a commit to an open PR or when any person merges the commit to main branch.

Can you please explain more on what changes are you suggesting here?

@rootxrishabh
Copy link
Member Author

Hi @kranurag7, thanks for the info. I think to put it better, we could have the action run on an open PR or before it is merged. What do you think?

@rootxrishabh rootxrishabh changed the title [Bug] Broken-link-check action not working [feat] Improving Broken-link-check scope Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants