Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): publish KubeArmorOperator Helm charts #1347

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

DelusionalOptimist
Copy link
Member

@DelusionalOptimist DelusionalOptimist commented Aug 7, 2023

Purpose of PR?:

Description:

  • Moves KubeArmorOperator helm chart to deployments/helm so that it can be published by the chart releaser wf
  • Changes PR/commit authors to github bot for automatically created PRs and commits.
  • Changes branch from gh-pages to main.

Does this PR introduce a breaking change?
No

If the changes in this PR are manually verified, list down the scenarios covered::
Ran them on my own fork by creating a stable release.
Created PR: DelusionalOptimist#22
Published chart: DelusionalOptimist/charts@211e57b

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also copy the README for helm? Since we are syncing the charts itself maybe syncing the README also makes sense?

.github/workflows/ci-latest-helm-chart-release.yaml Outdated Show resolved Hide resolved
.github/workflows/ci-latest-helm-chart-release.yaml Outdated Show resolved Hide resolved
.github/workflows/ci-stable-release.yml Outdated Show resolved Hide resolved
@DelusionalOptimist
Copy link
Member Author

DelusionalOptimist commented Aug 7, 2023

Can we also copy the README for helm? Since we are syncing the charts itself maybe syncing the README also makes sense?

@daemon1024 The GH action that we are using only commits and pushes helm chart changes. So we'll have to update README manually or create a separate automated commit. WDYT?

@rksharma95
Copy link
Collaborator

please include the fix to use release namespace here also with this PR itself.

@DelusionalOptimist DelusionalOptimist force-pushed the publish-operator-helm branch 3 times, most recently from ea4770d to 2400bfc Compare August 8, 2023 13:20
@DelusionalOptimist
Copy link
Member Author

DelusionalOptimist commented Aug 9, 2023

@rksharma95 @daemon1024 I've added a commit which builds the operator with local paths for dependencies while taking care of docker build context. This will get us rid of the hassle of updating our packages upstream before we update the operator. PTAL.

@rksharma95
Copy link
Collaborator

@rksharma95 @daemon1024 I've added a commit which builds the operator with local paths for dependencies while taking care of docker build context. This will get us rid of the hassle of updating our packages upstream before we update the operator. PTAL.

KubeArmor/tree/main/deployments/get we need to add this path to test-operator and release-operator ci workflow.
should we merge controller-test and operator-test workflow and we can check for path which pkg got updated WDYT @DelusionalOptimist ?

@DelusionalOptimist
Copy link
Member Author

KubeArmor/tree/main/deployments/get we need to add this path to test-operator and release-operator ci workflow.
should we merge controller-test and operator-test workflow and we can check for path which pkg got updated WDYT @DelusionalOptimist ?

@rksharma95 If I understand correctly, we'll have a common workflow which builds images for controller and operator based on the paths changed in PR and then run KubeArmor using operator.
We can do it at the repository level. A common CI workflow for PRs which will check all paths, build images as needed, push them to some temporary registry and run the ginkgo tests. No need to build image in all the runtime-specific workflows. It'll save us a lot of time.
But we can do this and a lot of other refactoring. If the operator-test and controller-test workflow merge is not urgent, I propose we should keep it as a part of the CI refactor in v0.12? What do you say?

@rksharma95
Copy link
Collaborator

But we can do this and a lot of other refactoring. If the operator-test and controller-test workflow merge is not urgent, I propose we should keep it as a part of the CI refactor in v0.12? What do you say?

let's target it in v0.12 🚀

@daemon1024 daemon1024 merged commit ab1eb20 into kubearmor:main Aug 9, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants