Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI(tests) Use AssertCommand function in every test #1643

Open
PrimalPimmy opened this issue Feb 20, 2024 · 10 comments · May be fixed by #1791 or #1890
Open

CI(tests) Use AssertCommand function in every test #1643

PrimalPimmy opened this issue Feb 20, 2024 · 10 comments · May be fixed by #1791 or #1890
Assignees
@abhashsolanki18
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@PrimalPimmy
Copy link
Member

Feature Request

Short Description

The CI tests have been updated to use the Eventually function in the ginkgo tests, however we need to update all the tests, only KSP tests were updated recently.

Is your feature request related to a problem? Please describe the use case.

Today we might get flakey tests and we would need to have a retry logic for executing commands.

in all of our tests
Describe the solution you'd like

A new AssertCommand function was added recently to the utils package. Use this function instead of the K8sExecInPod() in all of our tests:

KubeArmor/tests/util/kartutil.go

Line 614 in 8ceb083

func AssertCommand(wp string, namespace string, cmd []string, match gomegaTypes.GomegaMatcher, eventual bool) {

NOTE: some the the exec operators do not compare/match with anything and are just meant for executing, in that case you can set Matchregexp(".*") wherever matching is not required.
@PrimalPimmy PrimalPimmy added the enhancement New feature or request label Feb 20, 2024
@PrimalPimmy PrimalPimmy changed the title CI(tests) CI(tests) Use AssertCommand function in every test Feb 20, 2024
@daemon1024 daemon1024 added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 21, 2024
@akshat-kaushik
Copy link

working on it ! pls assign

@rootxrishabh
Copy link
Member

Hey @akshat-kaushik thank you for your interest! Let us know if you have any questions.

@EraKin575
Copy link

Hi!I would like to work on this issue if its not being solved?Can anyone assign me this issue

@EraKin575 EraKin575 mentioned this issue Mar 19, 2024
Closed
7 tasks
@bhoopesh369
Copy link

Is this issue resolved?
coz i see the pr that's linked not merged

@bhoopesh369
Copy link

@rootxrishabh

@PrimalPimmy PrimalPimmy moved this to Prashant in Chore Cleanup Jun 13, 2024
@EraKin575 EraKin575 linked a pull request Jun 26, 2024 that will close this issue
Open
7 tasks
@Garvit-77
Copy link

hey @rootxrishabh is this issue open ?

@Prateeknandle
Copy link
Collaborator

@EraKin575 are you working on this or can we assign it to @Garvit-77 ?

@abhashsolanki18
Copy link

hey @rootxrishabh is this issue open? i have been working on it lately, can you please assign it to me.

@Garvit-77
Copy link

hey @rootxrishabh i was already working on this issue

@abhashsolanki18
Copy link

hey @Garvit-77 i have completed its solution and will be raising a PR for the same shortly.

@abhashsolanki18 abhashsolanki18 linked a pull request Nov 10, 2024 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhashsolanki18 abhashsolanki18

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Chore Cleanup
Status: Prashant
Milestone
No milestone
9 participants
@PrimalPimmy @daemon1024 @Prateeknandle @Garvit-77 @rootxrishabh @bhoopesh369 @akshat-kaushik @EraKin575 @abhashsolanki18