From 506cfe8fc6abd621d408624b92b1c19930e28060 Mon Sep 17 00:00:00 2001 From: "Matthieu Baerts (NGI0)" Date: Wed, 21 Aug 2024 19:02:46 +0200 Subject: [PATCH] contest: vmksft-p: skip even if not ok KTAP is clear about the 'SKIP' directive and the result [1]: > note the result of the test case result line can be either "ok" or > "not ok" if the SKIP directive is used Nothing seems to be imposed on TAP 13/14 side [2], so I suppose it is fine. We can then drop this restriction, and mark the test as 'skipped' if the directive is starting with 'skip'. Link: https://docs.kernel.org/dev-tools/ktap.html#test-case-result-lines [1] Link: https://testanything.org/tap-version-14-specification.html [2] Signed-off-by: Matthieu Baerts (NGI0) --- contest/remote/vmksft-p.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contest/remote/vmksft-p.py b/contest/remote/vmksft-p.py index 710720a..fe9e87a 100755 --- a/contest/remote/vmksft-p.py +++ b/contest/remote/vmksft-p.py @@ -101,7 +101,7 @@ def _parse_nested_tests(full_run): r = {'test': namify(v[3])} if len(v) > 5 and v[4] and v[5]: - if v[5].lower().startswith('skip') and result == "pass": + if v[5].lower().startswith('skip'): result = "skip" t = time_re.findall(v[5].lower())