Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appendS is unintuitive in its argument ordering #9

Open
gergoerdi opened this issue Mar 1, 2014 · 0 comments
Open

appendS is unintuitive in its argument ordering #9

gergoerdi opened this issue Mar 1, 2014 · 0 comments

Comments

@gergoerdi
Copy link
Member

I can't tell if appendS is wrong or just unintuitive, but it seems the left-hand argument is routed to the right-hand side of the output and vice verse:

λ> appendS (toS [2 :: U4]) (toS [0 :: U8]) :: Seq U12
2 | ? .
λ> flip appendS (toS [2 :: U4]) (toS [0 :: U8]) :: Seq U12
512 | ? .

If this is indeed the intended behaviour, could you at least change the documentation from

given two signals of a1 and a2 width, respectively, pack them into a signal of a1 + a2 width.

to something like

given two signals of a1 and a2 width, respectively, pack them into a signal of a2 + a1 (sic!) width.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant