Update opentelemetry example #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,14 +1,16 @@ | |||
| val opentelemetry_version: String by project | |||
| val opentelemetry_semconv_version: String by project | |||
| val opentelemetry_exporter_otlp_version: String by project | |||
Check warning
Code scanning / detekt
Variable names should follow the naming convention set in the projects configuration. Warning
| @@ -1,14 +1,16 @@ | |||
| val opentelemetry_version: String by project | |||
| val opentelemetry_semconv_version: String by project | |||
| val opentelemetry_exporter_otlp_version: String by project | |||
| val opentelemetry_sdk_extension_autoconfigure_version: String by project | |||
Check warning
Code scanning / detekt
Variable names should follow the naming convention set in the projects configuration. Warning
|
|
||
| plugins { | ||
| kotlin("jvm") version "2.0.20" | ||
| id("io.ktor.plugin") version "3.0.1" | ||
| } | ||
|
|
||
| dependencies { | ||
| implementation("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure:$opentelemetry_version"); | ||
| implementation("io.opentelemetry:opentelemetry-exporter-otlp:$opentelemetry_version"); | ||
| implementation("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure:$opentelemetry_sdk_extension_autoconfigure_version"); |
Check warning
Code scanning / detekt
Line detected that is longer than the defined maximum line length in the code style. Warning
e5l
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to update
opentelemetryexample because Ktor 3.0.0 support was added in2.10.0release ofopentelemetry-java-instrumentationhttps://youtrack.jetbrains.com/issue/KTOR-7515/Add-support-for-OpenTelemetry-plugin-for-3.x.x-versions#focus=Comments-27-11070747.0-0