Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on Microsoft Edge browser. #2

Open
canewsin opened this issue Mar 17, 2020 · 5 comments
Open

Not working on Microsoft Edge browser. #2

canewsin opened this issue Mar 17, 2020 · 5 comments

Comments

@canewsin
Copy link

site not detecting ZeroNet installation on new Microsoft edge browser.

@canewsin
Copy link
Author

ok found the problem, I was using dark mode extension, checking background colour is not reliable because extensions like, I use or chrome dark mode flag may interfere with these.

@krzysztof113
Copy link
Owner

krzysztof113 commented Mar 17, 2020

Yes, I even made a PR to bypass that problem but @HelloZeroNet never accepted it.
HelloZeroNet/ZeroHello#129

@HelloZeroNet
Copy link

Here is an example for easier check:

elem_local_test = createElem('<img src="http://127.0.0.1:43110/favicon.ico?random=' + Date.now() + '" style="display: none"/>');

elem_local_test.onerror = function() {
    document.getElementById("visit-links").classList.add("no-local");
};

https://github.com/HelloZeroNet/zeronet.io/blob/master/go.html#L68

@canewsin
Copy link
Author

@krzysztof113 what do you think about the @HelloZeroNet Suggestion ?

@krzysztof113
Copy link
Owner

Yes, I think I'll move to it. The only problem I've seen is when you have regular webserver on custom port then favicon will be there, with false positive, but the chance for that is negligible.
Overall why are you interested? You plan to use it somewhere in your app? There are barely any users by now.

Repository owner deleted a comment from canewsin Sep 17, 2021
Repository owner deleted a comment from canewsin Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants