Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation for / and /top/:page should highlight the "top" tab in header #2

Open
kristoferbaxter opened this issue May 22, 2017 · 0 comments
Open

Navigation for / and /top/:page should highlight the "top" tab in header #2

kristoferbaxter opened this issue May 22, 2017 · 0 comments

Comments

@kristoferbaxter
Copy link
Owner

kristoferbaxter commented May 22, 2017 •
edited
Loading

I don't see a way to pass a custom method to <NavLink> from React-Router for denoting it's active classes.

Idea 1:
Use a custom <Match> component to derive when either url pattern is matched and apply via standard classNames

Idea 2:
Modify React-Router to accept custom methods for determining active states.

Idea 3:
Move away from React-Router entirely and implement a custom router. (Likely don't have time for this).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kristoferbaxter