Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge React 1.0 changes to ERICA #82

Open
kristoferB opened this issue Jun 28, 2017 · 1 comment
Open

Merge React 1.0 changes to ERICA #82

kristoferB opened this issue Jun 28, 2017 · 1 comment
Assignees
@artokem @edvardlindelof
Labels
frontend
Milestone
Testing and integ...

Comments

@kristoferB
Copy link
Owner

The erica-branch needs to merge master to get the updated scalajs react 1.0 changes. Mainly fixing the conflicts and then update the erica specific widgets.
@kristoferB kristoferB added this to the Backlog milestone Jun 28, 2017
@kristoferB
Copy link
Owner Author

Some things not working after upgrade:

  • Filter input box is missing in header
  • SetState warning when opening Triage och statusdiagram (sometimes the widget is also empty since the data is not updated until a change occurs.)
  • Widget header should be collapsed as default.
  • The default size of various widgets are weird
  • When resizing the clock widget, smaller than the clock, we get: Warning: Failed prop type: minHeight larger than item height/maxHeight
  • Patientkort and lång tid sedan händelse gets: Error: Invalid value for attribute height="auto"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artokem artokem

@edvardlindelof edvardlindelof

Labels
frontend
Projects
None yet
Milestone
Testing and integration
Development

No branches or pull requests
3 participants
@kristoferB @artokem @edvardlindelof