Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple equal reactions from user are displayed multiple times #952

Closed
Kladki opened this issue Mar 24, 2024 · 2 comments
Closed

Multiple equal reactions from user are displayed multiple times #952

Kladki opened this issue Mar 24, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Kladki
Copy link

Kladki commented Mar 24, 2024

Bug Description

When multiple m.reaction events are sent from a user with the same key and rel_type from the same user, it causes their reactions to add up rather than just being displayed once.
Screenshot_2024-03-24-16-59-11-344-edit_chat fluffy fluffychat
Screenshot_2024-03-24-16-59-47-865-edit_chat fluffy fluffychat

Steps to Reproduce

  1. Send a message
  2. Get the event id
  3. Use element devtools to send this event multiple times of type m.reaction:
"m.relates_to": {
  "event_id": "${event_id}",
  "key": "👍",
  "rel_type": "m.annotation"
}
  1. See issue

Expected Behavior

Only one reaction of a certain emoji should be displayed for a single user.

Multiple identical annotations (i.e., with the same event type and annotation key) from the same user (i.e., events with the same sender) should be treated as a single annotation.

https://spec.matrix.org/v1.10/client-server-api/#annotations-client-behaviour

App Version

1.18.0

Additional Platform Information

Redmi Note 9 Pro, Android 12

Additional Context

Multiple reactions in the real world can be caused by buggy clients, multiple clients reacting at the same time, lag, etc.

@Kladki Kladki added the bug Something isn't working label Mar 24, 2024
@krille-chan
Copy link
Owner

Thanks for the bug report. I will move the issue to the sdk repo

@krille-chan
Copy link
Owner

Closed in favor of famedly/matrix-dart-sdk#1752

@krille-chan krille-chan closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants