Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested panes? #4

Open
kewaopcode opened this issue Jul 12, 2023 · 4 comments
Open

Nested panes? #4

kewaopcode opened this issue Jul 12, 2023 · 4 comments

Comments

@kewaopcode
Copy link

I don't see any way to draw a pane inside of another pane, is this even possible? Maybe this is a core idea to avoid nested panes? There is also no nested panes in the example.

@kewaopcode
Copy link
Author

I am thinking about the default Elm style composing, storing child's localstate in the parent's localstate and calling child's event handler inside of the parent's one, so the child isn't even declared in the global list of panes. Do you see any problems with this approach?

@kquick
Copy link
Owner

kquick commented Jul 12, 2023

I did some preliminary investigation into this many months ago and while I don't recall the specifics at the moment, it basically was not going to be very easy due to context that the nesting would impose, so I dropped the effort.

If this is something you are willing to invest effort into, I'd potentially be open to a pull request but I'd want to be cautious of adding more complexity to the API. Let me know if this is something you want to pursue and I will see if I can find the working dir where I was exploring this and if there are any details I can pass along.

@kewaopcode
Copy link
Author

Sure, i would like to see everything. I feel like i still didnt get the idea of Panes, so any additional material (codes, notes, etc) about this project would be interesting for me.

@kquick
Copy link
Owner

kquick commented Jul 13, 2023

I will be out for a couple of days, so I won't be able to respond until mid-next week.

It's often the case where the event management and rendering has global implications for handling in brick that would affect attempts at nesting. A good approach would probably be to start with a sample application that is implemented against the current brick-panes and then look at a modification of that application that would take advantage of this type of nested panes. If you could start by putting together this type of example, that would give a good candidate target to evaluate how these changes would need to occur in the brick-panes library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants