Settings Keeps reverting the h264EncoderArguments back to -c:v h264_vaapi / breaking transcoding with Intel quick sync

[miwagner1]

Describe the bug
Settings > transcoding > h264 Encoder Arguments reset back to -c:v h264_vaapi on the second video playthrough when testing HomeKit transcoding for remote streams.

To Reproduce
Steps to reproduce the behavior:

1. Go to Settings > transcoding > h264 Encoder Arguments
2. Set the argument to "-c:v h264_qsv"
3. Save
4. Go to a camera with Homekit and Transcoding enabled
5. Transcode all streams for testing
6. Set Video decoder arguments to "-hwaccel qsv -hwaccel_output_format qsv"
7. Save
8. Test by streaming the camera from Homekit (stream works)
9. Close the stream and open it again
10. Watch the Homekit stream fail to load
11. Check Settings > transcoding > h264 Encoder Arguments
12. See it changed back to "-c:v h264_vaapi"

Expected behavior
Video plays on iPhone from Homekit

Smartphone (please complete the following information):

• Device: iPhone 11
• OS: 17.1

Additional context
Tested on a fresh install with no previous volume data.

My Provider LTE is garbage and Scrypted Homekit stream likes to not load. I am able to reliably steam using https://github.com/hjdhjd/homebridge-unifi-protect (after layering the Homebridge image with a FFMPEG that works for my hardware) which likes to transcode the remote stream at a lower bitrate

Hardware: Beelink S12 Pro (intel N100)
Changed Scrypted Image FFMPEG a docker file from linuxserver with some small modifications to push the new build to the Scrypted image with https://github.com/linuxserver/docker-ffmpeg/blob/77720f84b1a1fa935ab4bae98a9d2ad92fedcb32/Dockerfile#L692

First attempt to stream the camera in Homekit is a success.

[HomeKit]: video codec/container not matched, transcoding: transcode {"url":"rtsp://127.0.0.1:37431/116c8063b6d6b8da","urls":["rtsp://10.0.4.26:37431/116c8063b6d6b8da"],"container":"rtsp","inputArguments":["-analyzeduration","0","-probesize","500000","-reorder_queue_size","0","-rtsp_transport","tcp","-f","rtsp","-i","rtsp://127.0.0.1:37431/116c8063b6d6b8da"],"mediaStreamOptions":{"id":"1","name":"Medium","video":{"codec":"h264","width":1280,"height":720,"bitrate":3000000,"minBitrate":32000,"maxBitrate":3000000,"fps":24,"idrIntervalMillis":4000,"h264Info":{"fuab":false,"stapb":false,"mtap16":false,"mtap32":false,"sei":false,"reserved0":false,"reserved30":false,"reserved31":false}},"audio":{"codec":"opus"},"tool":"scrypted","container":"rtsp","sdp":"v=0\r\no=- 18055 0 IN IP4 10.0.4.10\r\ns=D021F997E7B9_1\r\nu=www.ui.com\r\[email protected]\r\nc=IN IP4 10.0.4.10\r\nt=0 0\r\na=recvonly\r\na=control:*\r\na=range:npt=now-\r\nm=audio 0 RTP/AVP 96\r\na=recvonly\r\na=rtpmap:96 opus/48000/2\r\na=control:trackID=1\r\na=fmtp:96\r\nm=video 0 RTP/AVP 97\r\na=recvonly\r\na=control:trackID=2\r\na=rtpmap:97 H264/90000\r\na=fmtp:97 profile-level-id=4d401f; packetization-mode=1; sprop-parameter-sets=Z01AH42NQCgC3/gLcBAQFAAAD6AAAu4CdoIhGoA=,aO44gA==","prebuffer":2000,"prebufferBytes":0},"h264EncoderArguments":["-c:v","h264_qsv"],"destinationVideoBitrate":1000000,"videoDecoderArguments":["-hwaccel","qsv","-hwaccel_output_format","qsv"]}
[HomeKit]: -hide_banner -hwaccel qsv -hwaccel_output_format qsv -analyzeduration 0 -probesize 500000 -reorder_queue_size 0 -rtsp_transport tcp -f rtsp -i rtsp:[REDACTED] -c:v h264_qsv -filter_complex scale=w='min(1280,iw)':h=-2 -b:v 1000000 -bufsize 2000000 -maxrate 1000000 -g 120 -r 30 -payload_type 99 -ssrc 8614446 -srtp_out_suite AES_CM_128_HMAC_SHA1_80 -srtp_out_params WbJW9P5sp7Ll5sTyTu/vM5ZsOWc+ooR8FaFNUJEO -dn -sn -an -f rtp srtp://10.0.4.226:62365?rtcpport=62365&pkt_size=1378 -acodec libopus -application lowdelay -frame_duration 60 -flags +global_header -ar 24k -b:a 24k -bufsize 96k -ac 1 -payload_type 110 -ssrc 13041481 -dn -sn -vn -f rtp rtp://127.0.0.1:59303?pkt_size=400 -sdp_file pipe:4
[Rebroadcast Plugin]: Medium active rebroadcast clients: 

The second attempt is a failure due to scrypted auto changing the encoder.

[HomeKit]: video codec/container not matched, transcoding: transcode {"url":"rtsp://127.0.0.1:42415/40b20e2676c663ed","urls":["rtsp://10.0.4.26:42415/40b20e2676c663ed"],"container":"rtsp","inputArguments":["-analyzeduration","0","-probesize","500000","-reorder_queue_size","0","-rtsp_transport","tcp","-f","rtsp","-i","rtsp://127.0.0.1:42415/40b20e2676c663ed"],"mediaStreamOptions":{"id":"1","name":"Medium","video":{"codec":"h264","width":1280,"height":720,"bitrate":3000000,"minBitrate":32000,"maxBitrate":3000000,"fps":24,"idrIntervalMillis":4000,"h264Info":{"fuab":false,"stapb":false,"mtap16":false,"mtap32":false,"sei":false,"reserved0":false,"reserved30":false,"reserved31":false}},"audio":{"codec":"opus"},"tool":"scrypted","container":"rtsp","sdp":"v=0\r\no=- 18067 0 IN IP4 10.0.4.10\r\ns=D021F997E7B9_1\r\nu=www.ui.com\r\[email protected]\r\nc=IN IP4 10.0.4.10\r\nt=0 0\r\na=recvonly\r\na=control:*\r\na=range:npt=now-\r\nm=audio 0 RTP/AVP 96\r\na=recvonly\r\na=rtpmap:96 opus/48000/2\r\na=control:trackID=1\r\na=fmtp:96\r\nm=video 0 RTP/AVP 97\r\na=recvonly\r\na=control:trackID=2\r\na=rtpmap:97 H264/90000\r\na=fmtp:97 profile-level-id=4d401f; packetization-mode=1; sprop-parameter-sets=Z01AH42NQCgC3/gLcBAQFAAAD6AAAu4CdoIhGoA=,aO44gA==","prebuffer":2000,"prebufferBytes":0},"h264EncoderArguments":["-c:v","h264_vaapi"],"destinationVideoBitrate":1000000,"videoDecoderArguments":["-hwaccel","qsv","-hwaccel_output_format","qsv"]}
[HomeKit]: -hide_banner -hwaccel qsv -hwaccel_output_format qsv -analyzeduration 0 -probesize 500000 -reorder_queue_size 0 -rtsp_transport tcp -f rtsp -i rtsp:[REDACTED] -c:v h264_vaapi -filter_complex scale=w='min(1280,iw)':h=-2 -b:v 1000000 -bufsize 2000000 -maxrate 1000000 -g 120 -r 30 -payload_type 99 -ssrc 8652586 -srtp_out_suite AES_CM_128_HMAC_SHA1_80 -srtp_out_params 4TtJD0WbW/4p9+aun+BJSNg9OBSWkrGhfgHy2Utm -dn -sn -an -f rtp srtp://10.0.4.226:50170?rtcpport=50170&pkt_size=1378 -acodec libopus -application lowdelay -frame_duration 60 -flags +global_header -ar 24k -b:a 24k -bufsize 96k -ac 1 -payload_type 110 -ssrc 15335693 -dn -sn -vn -f rtp rtp://127.0.0.1:50784?pkt_size=400 -sdp_file pipe:

[koush]

duplicate #522