Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev env: Change app deployment script to use gh-pages #37

Open
OleksiyRudenko opened this issue May 17, 2021 · 1 comment
Open

dev env: Change app deployment script to use gh-pages #37

OleksiyRudenko opened this issue May 17, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@OleksiyRudenko
Copy link
Member

OleksiyRudenko commented May 17, 2021

Issue 1

Problem:
a8e06ad (currently on dev) brings back push-dir as a publishing script.
Alternative deployment package gh-pages is already listed among dev dependencies.

Desired outcome:
gh-pages is used as a publishing method.

Suggested approach:
package.json: change deploy script so that it runs gh-pages -d dist

Issue 2

Problem:
a8e06ad (currently on dev) brings back shell interpretation of glob passed to npx prettier.

Desired outcome:
npx prettier glob is quoted and therefore interpreted by prettier, not shell.

Suggested approach:
package.json: change prettify script so that it runs npx prettier --write \"**/*.{js,css,md,html}\"

@OleksiyRudenko OleksiyRudenko added the enhancement New feature or request label May 17, 2021
@OleksiyRudenko OleksiyRudenko self-assigned this May 18, 2021
@OleksiyRudenko OleksiyRudenko added bug Something isn't working and removed enhancement New feature or request labels May 18, 2021
@mykyta-shulipa
Copy link
Collaborator

This would change only package.json so I think it'd be safe to make PR and merge to dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants