Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two little things in the documentation... #8

Open
dr-falsch opened this issue Mar 9, 2016 · 2 comments
Open

two little things in the documentation... #8

dr-falsch opened this issue Mar 9, 2016 · 2 comments

Comments

@dr-falsch
Copy link

Hello,

I think I found two little mistakes in the documentation...

1.) In the "Enables Log" part it should be the other way around: If you don't set "-DDISABLE_LOG" logging will be enabled by default. But the documentation states that you have to set "ENABLE_LOG" to enable logging.

If I understand it correctly, you'd just set "-DDISABLE_LOG" in the "Release"-Part and leave the "Debug"-Part empty.

2.) If you manually install it, like in the documentation by just copying the swift-files, then the color logging will not be available and the "import SpeedLog" part is not necessary. If you do it like in the Alamofire documentation (https://github.com/Alamofire/Alamofire#manually) by copying the complete folder, drag'n drop the .xcodeproj file, everything works fine.

Thanx for this great piece of code! :-)

@Trexology
Copy link

Thanks for opening this issue... was trying so hard to find out whats wrong

@kostiakoval
Copy link
Owner

that for the comments, I will review the readme and will fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants