ravif: Add #[deprecated] notice to ColorSpace
#91
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit e03108a ("Rename color space → model") (for kornelski#88) added/kept hidden variants of `ColorSpace` and `with_internal_color_space()` for backwards compatibility, to not need a semver-breaking release. Unfortunately these were not annotated with `#[deprecated]`, making users unaware of this change until they would (if ever) upgrade to the next breaking release of `ravif` where such helpers are supposedly going to be removed again. Tell users about this with a `#[deprecated]` notice to guide them to the new item names.
MarijnS95
force-pushed
the
deprecated
branch
from
3eac87b to
1dbf8bf
Compare
|
It's a cosmetic change, so I didn't want bother users about it. |
|
I'd argue it's useful to point them in the right direction, not purely cosmetic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit e03108a ("Rename color space → model") (for #88) added/kept hidden variants of
ColorSpaceandwith_internal_color_space()for backwards compatibility, to not need a semver-breaking release. Unfortunately these were not annotated with#[deprecated], making users unaware of this change until they would (if ever) upgrade to the next breaking release ofravifwhere such helpers are supposedly going to be removed again.Tell users about this with a
#[deprecated]notice to guide them to the new item names.