Fix usage of BigInteger in DiscordBitSet.value
#864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiscordBitSet can only represent positive numbers, so the BigInteger used for getting a decimal representation can be constructed using the sign-magnitude representation instead of the two's-complement binary representation. This fixes two bugs: * DiscordBitSets with an empty data array couldn't be converted to a BigInteger because the constructor taking the two's-complement binary representation throws a NumberFormatException if the given array is empty. This bug was reported by @Tmpod: https://discord.com/channels/556525343595298817/1147254164469063773 * DiscordBitSets with a negative Long at the last position in their data array would be misinterpreted as negative numbers in the conversion to BigIntegers because the two's-complement binary representation was used. Example where this bug could be observed: // printed -9223372036854775808, should be 9223372036854775808 println(DiscordBitSet(1L shl 63).value)
|
Tested this on my affected project and it's all good now, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiscordBitSetcan only represent positive numbers, so theBigIntegerused for getting a decimal representation can be constructed using the sign-magnitude representation instead of the two's-complement binary representation.This fixes two bugs:
DiscordBitSets with an emptydataarray couldn't be converted to aBigIntegerbecause the constructor taking the two's-complement binary representation throws aNumberFormatExceptionif the given array is empty.This bug was reported by @Tmpod: https://discord.com/channels/556525343595298817/1147254164469063773
DiscordBitSetswith a negativeLongat the last position in theirdataarray would be misinterpreted as negative numbers in the conversion toBigIntegers because the two's-complement binary representation was used.Example where this bug could be observed: