Add MediaChannels
#853
Merged
Add MediaChannels
#853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think one thing that could still be improved is to have a common supertype for the create / edit builders, they are mostly copy-pasted from the forum ones |
lukellmann
force-pushed
the
media-channels
branch
from
308f5e8 to
a49c648
Compare
|
Yeey a new channel interface |
lukellmann
force-pushed
the
media-channels
branch
from
a49c648 to
8494434
Compare
lukellmann
force-pushed
the
media-channels
branch
4 times, most recently
from
94b1864 to
e80d5c8
Compare
i've decided that this can be done in a separate pr, so this one doesn't take longer than necessary |
Common functionality between ForumChannel and MediaChannel was extracted to a new ThreadOnlyChannel supertype. See discord/discord-api-docs#6232
lukellmann
force-pushed
the
media-channels
branch
from
e80d5c8 to
09d34aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common functionality between
ForumChannelandMediaChannelwas extracted to a newThreadOnlyChannelsupertype.see discord/discord-api-docs#6232