Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Большаков Николай #256

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
66f225d
Create homework project
stupidnessplusplus Nov 13, 2024
c0293fc
Add ICircularCloudLayouter.cs
stupidnessplusplus Nov 13, 2024
7183fc6
Add spiral layouter
stupidnessplusplus Nov 13, 2024
344d04e
Add tests
stupidnessplusplus Nov 13, 2024
aab0770
Add RectanglesVisualizer.cs
stupidnessplusplus Nov 13, 2024
1b644f3
Add pictures
stupidnessplusplus Nov 13, 2024
04dc69c
Add SizeParser.cs
stupidnessplusplus Nov 17, 2024
9f9d08e
Add Program.cs with Main method
stupidnessplusplus Nov 17, 2024
9e00853
Change RectanglesVisualizer
stupidnessplusplus Nov 17, 2024
a516105
Add failed tests visualization
stupidnessplusplus Nov 17, 2024
8ab4c3d
Fix exception when creating empty image
stupidnessplusplus Nov 19, 2024
f9d9483
Add homework projects to tdd solution
stupidnessplusplus Nov 19, 2024
eb47d4f
Delete CircularCloudLayouter_Constructor_Tests.cs
stupidnessplusplus Nov 22, 2024
9dffe35
Rename tests class
stupidnessplusplus Nov 22, 2024
1cc941b
Remove public Center property
stupidnessplusplus Nov 22, 2024
16f8ea4
Style changes
stupidnessplusplus Nov 22, 2024
82eefab
Rewrite test using linq
stupidnessplusplus Nov 22, 2024
e19896c
Remove Debug.Assert
stupidnessplusplus Nov 25, 2024
9ade8c9
Add DirectionOperations.cs
stupidnessplusplus Nov 25, 2024
c493b78
Store direction to previous rectangle
stupidnessplusplus Nov 25, 2024
47fc9fa
Change to iteration by directions
stupidnessplusplus Nov 25, 2024
7fa5911
Rewrite using SortedList
stupidnessplusplus Nov 25, 2024
ca73e6c
Add ability to run with random sizes
stupidnessplusplus Nov 25, 2024
b1b1fc2
Add example sizes file
stupidnessplusplus Nov 25, 2024
74e492e
Remove method for second rectangle
stupidnessplusplus Nov 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove public Center property
stupidnessplusplus committed Nov 22, 2024
commit 1cc941b1b9f7ce9c98e47814dac6c0bc6a84e0c2
7 changes: 3 additions & 4 deletions homework/TagsCloud/SpiralCircularCloudLayouter.cs
Original file line number Diff line number Diff line change
@@ -8,18 +8,17 @@ public class SpiralCircularCloudLayouter
{
private readonly SortedRectanglesList _rectangles;
private readonly List<Rectangle> _rectanglesSpiralStack;
private readonly Point _center;

public SpiralCircularCloudLayouter(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

поправим форматирование?

Point center)
{
_rectangles = new SortedRectanglesList();
_rectanglesSpiralStack = [];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно инициализировать при объявлении (на мой вкус так более читабельно)


Center = center;
_center = center;
}

public Point Center { get; }

public Rectangle PutNextRectangle(
Size rectangleSize)
{
@@ -41,7 +40,7 @@ private Rectangle GetNextRectangle(
{
Debug.Assert(_rectangles.Count == 0);

return GetFirstRectangle(rectangleSize, Center);
return GetFirstRectangle(rectangleSize, _center);
}

if (_rectanglesSpiralStack.Count == 1)