-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Большаков Николай #256
Open
stupidnessplusplus
wants to merge
25
commits into
kontur-courses:master
Choose a base branch
from
stupidnessplusplus:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,207
−4
Open
Большаков Николай #256
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
66f225d
Create homework project
stupidnessplusplus c0293fc
Add ICircularCloudLayouter.cs
stupidnessplusplus 7183fc6
Add spiral layouter
stupidnessplusplus 344d04e
Add tests
stupidnessplusplus aab0770
Add RectanglesVisualizer.cs
stupidnessplusplus 1b644f3
Add pictures
stupidnessplusplus 04dc69c
Add SizeParser.cs
stupidnessplusplus 9f9d08e
Add Program.cs with Main method
stupidnessplusplus 9e00853
Change RectanglesVisualizer
stupidnessplusplus a516105
Add failed tests visualization
stupidnessplusplus 8ab4c3d
Fix exception when creating empty image
stupidnessplusplus f9d9483
Add homework projects to tdd solution
stupidnessplusplus eb47d4f
Delete CircularCloudLayouter_Constructor_Tests.cs
stupidnessplusplus 9dffe35
Rename tests class
stupidnessplusplus 1cc941b
Remove public Center property
stupidnessplusplus 16f8ea4
Style changes
stupidnessplusplus 82eefab
Rewrite test using linq
stupidnessplusplus e19896c
Remove Debug.Assert
stupidnessplusplus 9ade8c9
Add DirectionOperations.cs
stupidnessplusplus c493b78
Store direction to previous rectangle
stupidnessplusplus 47fc9fa
Change to iteration by directions
stupidnessplusplus 7fa5911
Rewrite using SortedList
stupidnessplusplus ca73e6c
Add ability to run with random sizes
stupidnessplusplus b1b1fc2
Add example sizes file
stupidnessplusplus 74e492e
Remove method for second rectangle
stupidnessplusplus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove public Center property
commit 1cc941b1b9f7ce9c98e47814dac6c0bc6a84e0c2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,18 +8,17 @@ public class SpiralCircularCloudLayouter | |
{ | ||
private readonly SortedRectanglesList _rectangles; | ||
private readonly List<Rectangle> _rectanglesSpiralStack; | ||
private readonly Point _center; | ||
|
||
public SpiralCircularCloudLayouter( | ||
Point center) | ||
{ | ||
_rectangles = new SortedRectanglesList(); | ||
_rectanglesSpiralStack = []; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. можно инициализировать при объявлении (на мой вкус так более читабельно) |
||
|
||
Center = center; | ||
_center = center; | ||
} | ||
|
||
public Point Center { get; } | ||
|
||
public Rectangle PutNextRectangle( | ||
Size rectangleSize) | ||
{ | ||
|
@@ -41,7 +40,7 @@ private Rectangle GetNextRectangle( | |
{ | ||
Debug.Assert(_rectangles.Count == 0); | ||
|
||
return GetFirstRectangle(rectangleSize, Center); | ||
return GetFirstRectangle(rectangleSize, _center); | ||
} | ||
|
||
if (_rectanglesSpiralStack.Count == 1) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
поправим форматирование?