-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: vultr installation #787
Conversation
@Seven45 Thanks for the PR, I'll test it today and get back to you. |
FYI, @jokestax is fixing something else for Vultr that need to be fixed before we can test this PR. Once it's done, he will also test this one. |
His PR was merged, so I'll be able to test this one. |
I'll need to give it another try tomorrow. I had an issue that isn't related to this PR. |
@fharper that pr solves the issue,i have upgraded it to 1.30,so you can test that branch itself:) |
@Seven45 so sorry but someone else on the team updated the Kubernetes version by fixing another issue, which mean this PR has now no changes, or would have been a version lower than what we decided to use. I'm so sorry, would have love to merge your commit as a contributor. With that said, thanks a lot for this PR as it helped us find that Vultr wasn't working anymore. We are implementing better daily testing to ensure this does not happen anymore. Even if I need to close this PR, I consider you a contributor, and would love to send you some swag as a token of our appreciation. Can you ping me on our Slack community (I'm @fred) or by email at [email protected]. |
Description
bump
kubernetes_version
fromv1.28.2+1
tov1.28.9+1
Related Issue(s)
Fixes konstructio/kubefirst#2261
How to test