Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI should not exit with code 0 when there was an issue #1885

Open
1 task done
fharper opened this issue Oct 31, 2023 · 2 comments
Open
1 task done

CLI should not exit with code 0 when there was an issue #1885

fharper opened this issue Oct 31, 2023 · 2 comments
Labels
bug Something isn't working ux User Experience improvements

Comments

@fharper
Copy link
Contributor

fharper commented Oct 31, 2023

Which version of kubefirst are you using?

2.3.3

Which cloud provider?

None specific

Which DNS?

None specific

Which installation type?

None specific

Which distributed Git provider?

None specific

Which Operating System?

macOS

What is the issue?

The CLI exit code is now always 0, even when the command didn't work properly. It is preventing automation using the exit code.

CleanShot 2023-10-31 at 10 19 00@2x

In that case, the exit code should be non-zero, usually 1. It wasn't an issue prior to the CLI revamp. I also assume it is like that for all commands, not just the create one.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@fharper fharper added the bug Something isn't working label Oct 31, 2023
@fharper fharper added the ux User Experience improvements label Apr 1, 2024
@fharper
Copy link
Contributor Author

fharper commented Apr 1, 2024

This issue is really problematic if you do any kind of automation using the kubefirst CLI.

@fharper
Copy link
Contributor Author

fharper commented Jul 8, 2024

To reproduce easily, just create a gitops repository in your personal account, and try to create a k3d cluster. The preflight checks will fail because of the repository already existing, and the code returned will be 0, when it should be anything other than 0 since the command wasn't successful.

CleanShot 2024-07-08 at 10 56 33@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ux User Experience improvements
Projects
None yet
Development

No branches or pull requests

2 participants