Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitOps catalog failed to load if there are single quotes inside an app secret label #1781

Closed
1 task done
fharper opened this issue Aug 29, 2023 · 3 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@fharper
Copy link
Contributor

fharper commented Aug 29, 2023

Which version of kubefirst are you using?

ALL

Which cloud provider?

None specific

Which installation type?

UI (Console app)

Which distributed Git provider?

None specific

What is the issue?

GitOps catalog failed to load if there are single quotes inside an app secret label. The error json: cannot unmarshal object into Go struct field GitopsCatalogAppSecretKey.secret_keys.value of type string, so I assume we do not sanitize the content. Probably worth checking all string values as it may be an issue with other properties.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@fharper fharper added the bug Something isn't working label Aug 29, 2023
@tomekz
Copy link

tomekz commented Oct 17, 2023

Hey I would like to work on this issue

@tomekz
Copy link

tomekz commented Oct 18, 2023

@fharper I can't reproduce the issue. Can you provide stacktrace or more details where is the error thrown?
I could be tweaking the wrong file ? It is yaml and the error is thrown by json encoder

@fharper
Copy link
Contributor Author

fharper commented Oct 23, 2023

@tomekz sorry about that, it was also fixed. We need to be better at closing our resolved issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants