CI test with CUDA 11.0 + Perfetto connector fix (bringing PR 212 to completion) #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/__w/kokkos-tools/kokkos-tools/profiling/perfetto-connector/perfetto/perfetto.h:7153:35: error: 'BUILTIN_CLOCK_UNKNOWN' was not declared in this scope
7153 | BuiltinClock primary_trace_clock_{};
Merge from develop this change
…2 on cicd: test Cuda version supported by Kokkos
/__w/kokkos-tools/kokkos-tools/profiling/perfetto-connector/perfetto/perfetto.h:7153:35: error: 'BUILTIN_CLOCK_UNKNOWN' was not declared in this scope
7153 | BuiltinClock primary_trace_clock_{};
vlkale
added
bug
Build
vlkale
changed the title
vlkale
changed the title
vlkale
changed the title
|
Closed because part was merged rest with #271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of PR #212, based on review and fixes of that PR and trying to address an associated problem /bug with Perfetto connector that is invoked when using CUDA-11.0, as discussed with @crtrott.
Note that the problem is from perfetto/perfetto.cc and not the Perfetto Kokkos Tools connector.
This PR also may address a Kokkos Tools Issue #259 from a Kokkos Tools user, but more discussion with the user is needed to see if it does fix it for their setup/environment/compilers that they are using for Perfetto.