Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for randomized sampling #181
Allow for randomized sampling #181
Changes from 10 commits
fc36b9d
a18b328
abafd7a
3bede60
a0a1bd2
7d2302d
5e4f762
6269ab4
c7c724c
9830c58
4e5c4a4
d7aa5bc
3254951
f236b87
c05a65f
79ebc63
75b23d7
cf105ff
a9cb706
5db6e8c
278bfe0
687bdd2
b606098
82b2423
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If both tool_prob_num < 0 and kernelSampleSkip is max of uint64_t set tool_prob_num to 10.0
Make an error check checking that not. both of them are set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
tool_prob_num
default has been assigned to the default requested. ThekernelSampleSkip
default is part of a new PR which focuses just on the correct matching of sampled kernels.